r112382 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112381‎ | r112382 | r112383 >
Date:01:44, 25 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/StreamFile.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/FileBackend.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/filerepo/backend/FileBackend.php
@@ -1246,7 +1246,9 @@
12471247 if ( $res == StreamFile::NOT_MODIFIED ) {
12481248 // do nothing; client cache is up to date
12491249 } elseif ( $res == StreamFile::READY_STREAM ) {
 1250+ wfProfileIn( __METHOD__ . '-send' );
12501251 $status = $this->doStreamFile( $params );
 1252+ wfProfileOut( __METHOD__ . '-send' );
12511253 } else {
12521254 $status->fatal( 'backend-fail-stream', $params['src'] );
12531255 }
Index: branches/wmf/1.19wmf1/includes/StreamFile.php
@@ -29,7 +29,9 @@
3030 if ( $res == self::NOT_MODIFIED ) {
3131 $ok = true; // use client cache
3232 } elseif ( $res == self::READY_STREAM ) {
 33+ wfProfileIn( __METHOD__ . '-send' );
3334 $ok = readfile( $fname );
 35+ wfProfileOut( __METHOD__ . '-send' );
3436 } else {
3537 $ok = false; // failed
3638 }
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
3739 Merged /trunk/phase3/includes:r112381
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
3840 Merged /trunk/phase3:r112381

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112381More file streaming related profilingaaron01:43, 25 February 2012

Status & tagging log