r112532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112531‎ | r112532 | r112533 >
Date:22:31, 27 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/ImagePage.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/api (modified) (history)
  • /branches/wmf/1.19wmf1/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/filerepo/backend/FileBackend.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/specials (modified) (history)
  • /branches/wmf/1.19wmf1/includes/specials/SpecialWhatlinkshere.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/ImagePage.php
@@ -108,8 +108,6 @@
109109 }
110110 }
111111
112 - $this->showRedirectedFromHeader();
113 -
114112 if ( $wgShowEXIF && $this->displayImg->exists() ) {
115113 // @todo FIXME: Bad interface, see note on MediaHandler::formatMetadata().
116114 $formattedMetadata = $this->displayImg->formatMetadata();
Index: branches/wmf/1.19wmf1/includes/filerepo/backend/FileBackend.php
@@ -1241,7 +1241,7 @@
12421242 }
12431243
12441244 // Set output buffer and HTTP headers for stream
1245 - $extraHeaders = $params['headers'] ? $params['headers'] : array();
 1245+ $extraHeaders = isset( $params['headers'] ) ? $params['headers'] : array();
12461246 $res = StreamFile::prepareForStream( $params['src'], $info, $extraHeaders );
12471247 if ( $res == StreamFile::NOT_MODIFIED ) {
12481248 // do nothing; client cache is up to date
Index: branches/wmf/1.19wmf1/includes/api/ApiQueryLogEvents.php
@@ -198,25 +198,26 @@
199199 * @return array
200200 */
201201 public static function addLogParams( $result, &$vals, $params, $type, $action, $ts ) {
202 - $params = explode( "\n", $params );
203202 switch ( $type ) {
204203 case 'move':
205 - if ( isset( $params[0] ) ) {
206 - $title = Title::newFromText( $params[0] );
 204+ if ( isset( $params[ '4::target' ] ) ) {
 205+ $title = Title::newFromText( $params[ '4::target' ] );
207206 if ( $title ) {
208207 $vals2 = array();
209208 ApiQueryBase::addTitleInfo( $vals2, $title, 'new_' );
210209 $vals[$type] = $vals2;
211210 }
212211 }
213 - if ( isset( $params[1] ) && $params[1] ) {
 212+ if ( isset( $params[ '5::noredir' ] ) && $params[ '5::noredir' ] ) {
214213 $vals[$type]['suppressedredirect'] = '';
215214 }
216215 $params = null;
217216 break;
218217 case 'patrol':
219218 $vals2 = array();
220 - list( $vals2['cur'], $vals2['prev'], $vals2['auto'] ) = $params;
 219+ $vals2[ 'cur' ] = $params[ '4::curid' ];
 220+ $vals2[ 'prev' ] = $params[ '5::previd' ];
 221+ $vals2[ 'auto' ] = $params[ '6::auto' ];
221222 $vals[$type] = $vals2;
222223 $params = null;
223224 break;
@@ -250,6 +251,7 @@
251252 }
252253
253254 private function extractRowInfo( $row ) {
 255+ $logEntry = DatabaseLogEntry::newFromRow( $row );
254256 $vals = array();
255257
256258 if ( $this->fld_ids ) {
@@ -281,10 +283,10 @@
282284 self::addLogParams(
283285 $this->getResult(),
284286 $vals,
285 - $row->log_params,
286 - $row->log_type,
287 - $row->log_action,
288 - $row->log_timestamp
 287+ $logEntry->getParameters(),
 288+ $logEntry->getType(),
 289+ $logEntry->getSubtype(),
 290+ $logEntry->getTimestamp()
289291 );
290292 }
291293 }
Property changes on: branches/wmf/1.19wmf1/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
292294 Merged /trunk/phase3/includes/api:r112374,112383,112397,112408,112474
Index: branches/wmf/1.19wmf1/includes/specials/SpecialWhatlinkshere.php
@@ -51,6 +51,7 @@
5252 $out = $this->getOutput();
5353
5454 $this->setHeaders();
 55+ $this->outputHeader();
5556
5657 $opts = new FormOptions();
5758
Property changes on: branches/wmf/1.19wmf1/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
5859 Merged /trunk/phase3/includes/specials:r112397,112408,112474
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
5960 Merged /trunk/phase3/includes:r112374,112383,112397,112408,112474
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
6061 Merged /trunk/phase3:r112374,112383,112397,112408,112474

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112374Attempting to address bug 34653; It seems ApiQueryLogEvents has not kept up w...awjrichards23:39, 24 February 2012
r112383Fixed $headers check in streamFile() to use isset()aaron02:01, 25 February 2012
r112397Forgot to commit this file in r112396ialex16:00, 25 February 2012
r112408Fixes bug 34715 Image redirects show the "redirected from" subtitle twice....hartman20:30, 25 February 2012
r112474(bug 34736) empty limit on special pages causes navigation issues...hashar10:17, 27 February 2012

Status & tagging log