r112474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112473‎ | r112474 | r112475 >
Date:10:17, 27 February 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
(bug 34736) empty limit on special pages causes navigation issues

On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).

The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.
Modified paths:
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Pager.php
——@@ -472,7 +472,7 @@
473473 }
474474
475475 # Don't announce the limit everywhere if it's the default
476 - $urlLimit = $this->mLimit == $this->mDefaultLimit ? '' : $this->mLimit;
 476+ $urlLimit = $this->mLimit == $this->mDefaultLimit ? null : $this->mLimit;
477477
478478 if ( $this->mIsFirst ) {
479479 $prev = false;

Sign-offs

UserFlagDate
Nikerabbitinspected10:49, 27 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112475MFT to 1.19wmf1 r112474...hashar10:22, 27 February 2012
r112532MFT r112374, r112383, r112397, r112408, r112474reedy22:31, 27 February 2012
r112647MFT r112384, r112400, r112408, r112451, r112456, r112474, r112526, r112533, r...reedy21:21, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105809Update wfArrayToCGI and wfCgiToArray:...dantman18:25, 11 December 2011

Comments

#Comment by Hashar (talk | contribs)   10:18, 27 February 2012

Tagging for 1.19 since that is a regression :-]

Status & tagging log