r112184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112183‎ | r112184 | r112185 >
Date:02:45, 23 February 2012
Author:krinkle
Status:ok
Tags:
Comment:
Bug 34604 - [mw.config] wgActionPaths should be an object instead of a numeral array JavaScript
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -245,6 +245,8 @@
246246 around a bug where not all styles were applied in Internet Explorer
247247 * (bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist.
248248 * (bug 34600) Older skins using useHeadElement=false were broken in 1.18
 249+* (bug 34604) [mw.config] wgActionPaths should be an object instead of a numeral
 250+ array.
249251
250252 === API changes in 1.19 ===
251253 * Made action=edit less likely to return "unknownerror", by returning the actual error
Index: trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -68,7 +68,9 @@
6969 'wgScriptExtension' => $wgScriptExtension,
7070 'wgScript' => $wgScript,
7171 'wgVariantArticlePath' => $wgVariantArticlePath,
72 - 'wgActionPaths' => $wgActionPaths,
 72+ // Force object to avoid "empty" associative array from
 73+ // becoming [] instead of {} in JS (bug 34604)
 74+ 'wgActionPaths' => (object)$wgActionPaths,
7375 'wgServer' => $wgServer,
7476 'wgUserLanguage' => $context->getLanguage(),
7577 'wgContentLanguage' => $wgContLang->getCode(),

Sign-offs

UserFlagDate
Nikerabbitinspected21:08, 23 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112249MFT r112179, r112184reedy22:11, 23 February 2012
r112644MFT r112169, r112170, r112172, r112173, r112179, r112184, r112290, r112313reedy21:13, 28 February 2012

Status & tagging log