r112249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112248‎ | r112249 | r112250 >
Date:22:11, 23 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/resourceloader (modified) (history)
  • /branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -68,7 +68,9 @@
6969 'wgScriptExtension' => $wgScriptExtension,
7070 'wgScript' => $wgScript,
7171 'wgVariantArticlePath' => $wgVariantArticlePath,
72 - 'wgActionPaths' => $wgActionPaths,
 72+ // Force object to avoid "empty" associative array from
 73+ // becoming [] instead of {} in JS (bug 34604)
 74+ 'wgActionPaths' => (object)$wgActionPaths,
7375 'wgServer' => $wgServer,
7476 'wgUserLanguage' => $context->getLanguage(),
7577 'wgContentLanguage' => $wgContLang->getCode(),
Property changes on: branches/wmf/1.19wmf1/includes/resourceloader
___________________________________________________________________
Modified: svn:mergeinfo
7678 Merged /trunk/phase3/includes/resourceloader:r112184
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
7779 Merged /trunk/phase3/includes:r112184
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.css
@@ -1,5 +1,7 @@
22 .feedback-spinner {
33 display: inline-block;
 4+ zoom: 1;
 5+ *display: inline; /* IE7 and below */
46 /* @embed */
57 background: url(mediawiki.feedback.spinner.gif);
68 width: 18px;
Index: branches/wmf/1.19wmf1/RELEASE-NOTES-1.19
@@ -248,6 +248,8 @@
249249 around a bug where not all styles were applied in Internet Explorer
250250 * (bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist.
251251 * (bug 34600) Older skins using useHeadElement=false were broken in 1.18
 252+* (bug 34604) [mw.config] wgActionPaths should be an object instead of a numeral
 253+ array.
252254
253255 === API changes in 1.19 ===
254256 * Made action=edit less likely to return "unknownerror", by returning the actual error
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
255257 Merged /trunk/phase3:r112179,112184

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112179Follow-up r112172: fix inline-block support for IE6/IE7krinkle01:25, 23 February 2012
r112184Bug 34604 - [mw.config] wgActionPaths should be an object instead of a numera...krinkle02:45, 23 February 2012

Status & tagging log