r112172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112171‎ | r112172 | r112173 >
Date:00:53, 23 February 2012
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module instead of Commons image

Switched from an <img> with a hardcoded Commons link to a <span>, a stylesheet, and a locally-hosted copy of the image.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.css (added) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.js (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif (added) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
@@ -554,6 +554,7 @@
555555 ),
556556 'mediawiki.feedback' => array(
557557 'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
 558+ 'styles' => 'resources/mediawiki/mediawiki.feedback.css',
558559 'dependencies' => array(
559560 'mediawiki.api.edit',
560561 'mediawiki.Title',
Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
@@ -106,7 +106,7 @@
107107 $( '<div class="feedback-mode feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
108108 mw.msg( 'feedback-adding' ),
109109 $( '<br/>' ),
110 - $( '<img src="//upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
 110+ $( '<span class="feedback-spinner"></span>' )
111111 ),
112112 $( '<div class="feedback-mode feedback-thanks" style="text-align:center;margin:1em"></div>' ).msg(
113113 'feedback-thanks', _this.title.getNameText(), $feedbackPageLink.clone()
Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/phase3/resources/mediawiki/mediawiki.feedback.spinner.gif
___________________________________________________________________
Added: svn:mime-type
114114 + image/gif
Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.css
@@ -0,0 +1,6 @@
 2+.feedback-spinner {
 3+ display: inline-block;
 4+ background: url(mediawiki.feedback.spinner.gif);
 5+ width: 18px;
 6+ height: 18px;
 7+}
Property changes on: trunk/phase3/resources/mediawiki/mediawiki.feedback.css
___________________________________________________________________
Added: svn:eol-style
18 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r112173Follow-up r112172: embedkrinkle01:00, 23 February 2012
r112174MFT r112169, r112172, r112173reedy01:02, 23 February 2012
r112179Follow-up r112172: fix inline-block support for IE6/IE7krinkle01:25, 23 February 2012
r112644MFT r112169, r112170, r112172, r112173, r112179, r112184, r112290, r112313reedy21:13, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112169bug 34599: special:uploadwizard loading insecure content from commons...brion00:37, 23 February 2012

Comments

#Comment by Krinkle (talk | contribs)   00:55, 23 February 2012

May wanna @embed it.

Status & tagging log