r112169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112168‎ | r112169 | r112170 >
Date:00:37, 23 February 2012
Author:brion
Status:ok (Comments)
Tags:
Comment:
bug 34599: special:uploadwizard loading insecure content from commons

This is in mediawiki.feedback module which is hosted in core.

A quick fix to load this spinner image protocol-relative. Should be replaced with CSS and a locally-hosted image.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
——@@ -106,7 +106,7 @@
107107 $( '<div class="feedback-mode feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
108108 mw.msg( 'feedback-adding' ),
109109 $( '<br/>' ),
110 - $( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
 110+ $( '<img src="//upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
111111 ),
112112 $( '<div class="feedback-mode feedback-thanks" style="text-align:center;margin:1em"></div>' ).msg(
113113 'feedback-thanks', _this.title.getNameText(), $feedbackPageLink.clone()

Follow-up revisions

RevisionCommit summaryAuthorDate
r112172* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module...brion00:53, 23 February 2012
r112174MFT r112169, r112172, r112173reedy01:02, 23 February 2012
r112644MFT r112169, r112170, r112172, r112173, r112179, r112184, r112290, r112313reedy21:13, 28 February 2012

Comments

#Comment by Krinkle (talk | contribs)   00:41, 23 February 2012

There's also bug 33045.

Status & tagging log