r112174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112173‎ | r112174 | r112175 >
Date:01:02, 23 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/resources/Resources.php (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.css (added) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.js (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.spinner.gif (added) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/resources/Resources.php
@@ -546,6 +546,7 @@
547547 ),
548548 'mediawiki.feedback' => array(
549549 'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
 550+ 'styles' => 'resources/mediawiki/mediawiki.feedback.css',
550551 'dependencies' => array(
551552 'mediawiki.api.edit',
552553 'mediawiki.Title',
Property changes on: branches/wmf/1.19wmf1/resources/Resources.php
___________________________________________________________________
Modified: svn:mergeinfo
553554 Merged /trunk/phase3/resources/Resources.php:r112172
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.js
@@ -106,7 +106,7 @@
107107 $( '<div class="feedback-mode feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
108108 mw.msg( 'feedback-adding' ),
109109 $( '<br/>' ),
110 - $( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
 110+ $( '<span class="feedback-spinner"></span>' )
111111 ),
112112 $( '<div class="feedback-mode feedback-thanks" style="text-align:center;margin:1em"></div>' ).msg(
113113 'feedback-thanks', _this.title.getNameText(), $feedbackPageLink.clone()
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.spinner.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.spinner.gif
___________________________________________________________________
Added: svn:mime-type
114114 + image/gif
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.css
@@ -0,0 +1,7 @@
 2+.feedback-spinner {
 3+ display: inline-block;
 4+ /* @embed */
 5+ background: url(mediawiki.feedback.spinner.gif);
 6+ width: 18px;
 7+ height: 18px;
 8+}
Property changes on: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.feedback.css
___________________________________________________________________
Added: svn:eol-style
19 + native
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
210 Merged /trunk/phase3:r112169,112172-112173

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112169bug 34599: special:uploadwizard loading insecure content from commons...brion00:37, 23 February 2012
r112172* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module...brion00:53, 23 February 2012
r112173Follow-up r112172: embedkrinkle01:00, 23 February 2012

Status & tagging log