r112034 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112033‎ | r112034 | r112035 >
Date:19:25, 21 February 2012
Author:brion
Status:resolved (Comments)
Tags:
Comment:
Followup r98045: fix bug 34504 wrt "Jump to" links in cached pages showing unexpectedly after 1.19 upgrade

Changed the updated styles to use the old (and still kept) id instead of the new (and thus not previously existing) class.
Should work on both old and new pages now.
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -1027,7 +1027,7 @@
10281028 }
10291029
10301030 /* Accessibility */
1031 -.mw-jump {
 1031+#jump-to-nav {
10321032 overflow: hidden;
10331033 height: 0;
10341034 zoom: 1; /* http://webaim.org/techniques/skipnav/#iequirk */

Follow-up revisions

RevisionCommit summaryAuthorDate
r112037Followup r112034, use both selectors not just one, don't break cached pages o...dantman20:23, 21 February 2012
r1120811.19wmf1: MFT r112034, r112037catrope03:47, 22 February 2012
r112162Merged revision r112034, r112037, r112100, r112141, r112152 from trunk/phase3reedy23:24, 22 February 2012
r112637MFT r111380, r111809, r111983, r112034, r112037, r112152reedy21:02, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98045Improve the accessibility of our jump-to functionality...dantman00:49, 25 September 2011

Comments

#Comment by Dantman (talk | contribs)   20:19, 21 February 2012

The intent of the .mw-jump class was to replace the #jump-to-nav, just like the .mw-body. So that we don't have to force these id's on 3rd party skins. This'll break in 3rd party skins. It should contain both selectors.

#Comment by Brion VIBBER (talk | contribs)   20:54, 21 February 2012

Do those third-party skins exist at this time, or can that be a decision for 1.20?

#Comment by Brion VIBBER (talk | contribs)   20:58, 21 February 2012

Ah good you have a followup fixing it anyway, so no worries. :DD

Status & tagging log