r112100 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112099‎ | r112100 | r112101 >
Date:11:33, 22 February 2012
Author:raymond
Status:ok (Comments)
Tags:
Comment:
r112061: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them.
But ignore them for translation per Nikerabbit: "I don't want these messages to be translated." https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329
Modified paths:
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -3579,6 +3579,32 @@
35803580 'logentry-newusers-autocreate',
35813581 'newuserlog-byemail',
35823582 ),
 3583+ 'logging-irc' => array(
 3584+ 'revdelete-logentry',
 3585+ 'logdelete-logentry',
 3586+ 'revdelete-content',
 3587+ 'revdelete-summary',
 3588+ 'revdelete-uname',
 3589+ 'revdelete-hid',
 3590+ 'revdelete-unhid',
 3591+ 'revdelete-log-message',
 3592+ 'logdelete-log-message',
 3593+ 'deletedarticle',
 3594+ 'suppressedarticle',
 3595+ 'undeletedarticle',
 3596+ 'patrol-log-line',
 3597+ 'patrol-log-auto',
 3598+ 'patrol-log-diff',
 3599+ '1movedto2',
 3600+ '1movedto2_redir',
 3601+ 'move-redirect-suppressed',
 3602+ 'newuserlog-byemail',
 3603+ 'newuserlog-create-entry',
 3604+ 'newuserlog-create2-entry',
 3605+ 'newuserlog-autocreate-entry',
 3606+ 'suppressedarticle',
 3607+ 'deletedarticle',
 3608+ ),
35833609 'feedback' => array(
35843610 'feedback-bugornote',
35853611 'feedback-subject',
@@ -3866,6 +3892,7 @@
38673893 'html-forms' => 'HTML forms',
38683894 'sqlite' => 'SQLite database support',
38693895 'logging' => 'New logging system',
 3896+ 'logging-irc' => 'For IRC, see bug 34508. Do not change',
38703897 'feedback' => 'Feedback',
38713898 'apierrors' => 'API errors',
38723899 );
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -192,6 +192,30 @@
193193 'longpage-hint',
194194 'javascripttest-backlink',
195195 'javascripttest-qunit-name',
 196+ 'revdelete-logentry',
 197+ 'logdelete-logentry',
 198+ 'revdelete-content',
 199+ 'revdelete-summary',
 200+ 'revdelete-uname',
 201+ 'revdelete-hid',
 202+ 'revdelete-unhid',
 203+ 'revdelete-log-message',
 204+ 'logdelete-log-message',
 205+ 'deletedarticle',
 206+ 'suppressedarticle',
 207+ 'undeletedarticle',
 208+ 'patrol-log-line',
 209+ 'patrol-log-auto',
 210+ 'patrol-log-diff',
 211+ '1movedto2',
 212+ '1movedto2_redir',
 213+ 'move-redirect-suppressed',
 214+ 'newuserlog-byemail',
 215+ 'newuserlog-create-entry',
 216+ 'newuserlog-create2-entry',
 217+ 'newuserlog-autocreate-entry',
 218+ 'suppressedarticle',
 219+ 'deletedarticle',
196220 );
197221
198222 /** Optional messages, which may be translated only if changed in the target language. */

Follow-up revisions

RevisionCommit summaryAuthorDate
r112162Merged revision r112034, r112037, r112100, r112141, r112152 from trunk/phase3reedy23:24, 22 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112061Bug 34508 - [Regression] IRC string output for log messages no longer compatible...reedy23:38, 21 February 2012

Comments

#Comment by Siebrand (talk | contribs)   12:32, 22 February 2012

Maybe set these to ignored, as they're solely used for irc and will be removed again (hopefully someday soon?).

#Comment by Siebrand (talk | contribs)   12:33, 22 February 2012

Oops. Should have read the complete commit message :). Excellent work.

#Comment by Hashar (talk | contribs)   12:07, 23 February 2012

Thanks Raymond!

Status & tagging log