r112162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112161‎ | r112162 | r112163 >
Date:23:24, 22 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Merged revision r112034, r112037, r112100, r112141, r112152 from trunk/phase3
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/SkinTemplate.php (modified) (history)
  • /branches/wmf/1.19wmf1/maintenance/language/messageTypes.inc (modified) (history)
  • /branches/wmf/1.19wmf1/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/maintenance/language/messages.inc
@@ -3578,6 +3578,34 @@
35793579 'logentry-newusers-autocreate',
35803580 'newuserlog-byemail',
35813581 ),
 3582+ 'logging-irc' => array(
 3583+ 'revdelete-logentry',
 3584+ 'logdelete-logentry',
 3585+ 'revdelete-content',
 3586+ 'revdelete-summary',
 3587+ 'revdelete-uname',
 3588+ 'revdelete-hid',
 3589+ 'revdelete-unhid',
 3590+ 'revdelete-log-message',
 3591+ 'logdelete-log-message',
 3592+ 'deletedarticle',
 3593+ 'suppressedarticle',
 3594+ 'undeletedarticle',
 3595+ 'patrol-log-line',
 3596+ 'patrol-log-auto',
 3597+ 'patrol-log-diff',
 3598+ '1movedto2',
 3599+ '1movedto2_redir',
 3600+ 'move-redirect-suppressed',
 3601+ 'newuserlog-byemail',
 3602+ 'newuserlog-create-entry',
 3603+ 'newuserlog-create2-entry',
 3604+ 'newuserlog-autocreate-entry',
 3605+ 'suppressedarticle',
 3606+ 'deletedarticle',
 3607+ 'uploadedimage',
 3608+ 'overwroteimage',
 3609+ ),
35823610 'feedback' => array(
35833611 'feedback-bugornote',
35843612 'feedback-subject',
@@ -3865,6 +3893,7 @@
38663894 'html-forms' => 'HTML forms',
38673895 'sqlite' => 'SQLite database support',
38683896 'logging' => 'New logging system',
 3897+ 'logging-irc' => 'For IRC, see bug 34508. Do not change',
38693898 'feedback' => 'Feedback',
38703899 'apierrors' => 'API errors',
38713900 );
Index: branches/wmf/1.19wmf1/maintenance/language/messageTypes.inc
@@ -191,6 +191,32 @@
192192 'longpage-hint',
193193 'javascripttest-backlink',
194194 'javascripttest-qunit-name',
 195+ 'revdelete-logentry',
 196+ 'logdelete-logentry',
 197+ 'revdelete-content',
 198+ 'revdelete-summary',
 199+ 'revdelete-uname',
 200+ 'revdelete-hid',
 201+ 'revdelete-unhid',
 202+ 'revdelete-log-message',
 203+ 'logdelete-log-message',
 204+ 'deletedarticle',
 205+ 'suppressedarticle',
 206+ 'undeletedarticle',
 207+ 'patrol-log-line',
 208+ 'patrol-log-auto',
 209+ 'patrol-log-diff',
 210+ '1movedto2',
 211+ '1movedto2_redir',
 212+ 'move-redirect-suppressed',
 213+ 'newuserlog-byemail',
 214+ 'newuserlog-create-entry',
 215+ 'newuserlog-create2-entry',
 216+ 'newuserlog-autocreate-entry',
 217+ 'suppressedarticle',
 218+ 'deletedarticle',
 219+ 'uploadedimage',
 220+ 'overwroteimage',
195221 );
196222
197223 /** Optional messages, which may be translated only if changed in the target language. */
Index: branches/wmf/1.19wmf1/RELEASE-NOTES-1.19
@@ -247,6 +247,7 @@
248248 * (bug 31676) Group dynamically inserted CSS into a single <style> tag, to work
249249 around a bug where not all styles were applied in Internet Explorer
250250 * (bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist.
 251+* (bug 34600) Older skins using useHeadElement=false were broken in 1.18
251252
252253 === API changes in 1.19 ===
253254 * Made action=edit less likely to return "unknownerror", by returning the actual error
Index: branches/wmf/1.19wmf1/includes/SkinTemplate.php
@@ -455,7 +455,7 @@
456456 if ( $this->useHeadElement ) {
457457 $tpl->set( 'headelement', $out->headElement( $this ) );
458458 } else {
459 - $tpl->set( 'headscripts', $out->getScript() );
 459+ $tpl->set( 'headscripts', $out->getHeadScripts() . $out->getHeadItems() );
460460 }
461461
462462 $tpl->set( 'debughtml', $this->generateDebugHTML() );
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
463463 Merged /trunk/phase3/includes:r112152
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
464464 Merged /trunk/phase3:r112034,112037,112100,112141,112152

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112034Followup r98045: fix bug 34504 wrt "Jump to" links in cached pages showing un...brion19:25, 21 February 2012
r112037Followup r112034, use both selectors not just one, don't break cached pages o...dantman20:23, 21 February 2012
r112100r112061: Add new message keys to maintenance files otherwise the next run of ...raymond11:33, 22 February 2012
r112141r112128: Add new message keys to maintenance files otherwise the next run of ...raymond20:00, 22 February 2012
r112152(bug 34600) Older skins using useHeadElement=false were broken in 1.18 . Modi...catrope21:43, 22 February 2012

Status & tagging log