r111809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111808‎ | r111809 | r111810 >
Date:00:42, 18 February 2012
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Add missing dependency of mediawiki.user to mediawiki.api.watch. May resolve some of bug 34450
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
——@@ -537,7 +537,7 @@
538538 ),
539539 'mediawiki.api.watch' => array(
540540 'scripts' => 'resources/mediawiki.api/mediawiki.api.watch.js',
541 - 'dependencies' => 'mediawiki.api',
 541+ 'dependencies' => array('mediawiki.api', 'mediawiki.user'),
542542 ),
543543 'mediawiki.debug' => array(
544544 'scripts' => 'resources/mediawiki/mediawiki.debug.js',

Follow-up revisions

RevisionCommit summaryAuthorDate
r111810MFT r111809werdna00:43, 18 February 2012
r112165Fix spacing in r111809catrope23:34, 22 February 2012
r112440[mediawiki.api.watch] Re-use watch() in unwatch()....krinkle15:57, 26 February 2012
r112637MFT r111380, r111809, r111983, r112034, r112037, r112152reedy21:02, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111685CollapsibleNav code wasn't run in a document ready hook. Maybe, just maybe, t...catrope21:30, 16 February 2012
r111804Fix weird bug where CSS was not loaded yet, and it was assumed that it would....werdna00:14, 18 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   09:46, 18 February 2012

Does not follow style wrt spaces around parenthesis.

#Comment by Krinkle (talk | contribs)   20:16, 26 February 2012

Should be user.tokens not mediawiki.user. Fixed in r112440.

Status & tagging log