r111821 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111820‎ | r111821 | r111822 >
Date:12:10, 18 February 2012
Author:siebrand
Status:resolved (Comments)
Tags:i18nreview 
Comment:
Use numbered variables. Follows-up r111272.
Modified paths:
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.i18n.php
——@@ -147,7 +147,7 @@
148148 'translate-checks-format' => 'This translation does not follow the definition or has invalid syntax: $1',
149149 'translate-checks-escape' => 'The following escapes may be accidental: <strong>$1</strong>',
150150 'translate-checks-parametersnotequal' => 'Parameter count is {{PLURAL:$1|$1}}; should be {{PLURAL:$2|$2}}.',
151 - 'translate-checks-malformed' => '<nowiki>$traArray[$i]</nowiki> is malformed.',
 151+ 'translate-checks-malformed' => '<nowiki>$1[$2]</nowiki> is malformed.',
152152 'translate-checks-fudforum-syntax' => 'Use <nowiki>$1</nowiki> instead of <nowiki>$2</nowiki> in this project.',
153153
154154 'translate-pref-nonewsletter' => 'Do not send me e-mail newsletters',

Follow-up revisions

RevisionCommit summaryAuthorDate
r111825Follow-up r111272, r111821: *facepalm*siebrand13:38, 18 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111272* Move hard coded styles in MessageWebImporter to CSS....siebrand04:45, 12 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   12:49, 18 February 2012

Still doesn't look right. The message is passed $defArray (which like the name says is an array) and $i, but the original text had the value of $traArray[$i] in it.

#Comment by Siebrand (talk | contribs)   13:35, 18 February 2012

Stupid me. Too text oriented.

Status & tagging log