r111822 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111821‎ | r111822 | r111823 >
Date:13:21, 18 February 2012
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Removed wfDeprecated() call from LogPage::logName() and LogPage::logHeader(); they are still widely used including in core.
Modified paths:
  • /trunk/phase3/includes/logging/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogPage.php
——@@ -175,7 +175,6 @@
176176 * @deprecated in 1.19, warnings in 1.21. Use getName()
177177 */
178178 public static function logName( $type ) {
179 - wfDeprecated( __METHOD__, '1.19' );
180179 global $wgLogNames;
181180
182181 if( isset( $wgLogNames[$type] ) ) {
——@@ -195,7 +194,6 @@
196195 * @deprecated in 1.19, warnings in 1.21. Use getDescription()
197196 */
198197 public static function logHeader( $type ) {
199 - wfDeprecated( __METHOD__, '1.19' );
200198 global $wgLogHeaders;
201199 return wfMsgExt( $wgLogHeaders[$type], array( 'parseinline' ) );
202200 }

Comments

#Comment by Nikerabbit (talk | contribs)   13:34, 18 February 2012

Could we please stop going back-and-forth with the deprecation warnings. I think the previous version where you can get the warnings *if you want* was better.

#Comment by IAlex (talk | contribs)   13:50, 18 February 2012

It is not correct to get warning when simply using core whithout extensions and with the default configuration. Period.

#Comment by Nikerabbit (talk | contribs)   13:53, 18 February 2012

Then change the default configuration?

#Comment by IAlex (talk | contribs)   14:13, 18 February 2012

And what for the comment at the beginning of the two chunks?

#Comment by Nikerabbit (talk | contribs)   17:01, 18 February 2012

They should stay, although alone they are useless for anyone who wants to find any fix deprecated use of stuff.

Status & tagging log