r111825 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111824‎ | r111825 | r111826 >
Date:13:38, 18 February 2012
Author:siebrand
Status:resolved (Comments)
Tags:i18nreview 
Comment:
Follow-up r111272, r111821: *facepalm*
Modified paths:
  • /trunk/extensions/Translate/MediaWikiMessageChecker.php (modified) (history)
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MediaWikiMessageChecker.php
@@ -236,8 +236,7 @@
237237 'translate-checks-format',
238238 wfMessage(
239239 'translate-checks-malformed',
240 - $defArray,
241 - $i
 240+ $defArray[$i]
242241 )->text()
243242 );
244243 continue;
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -147,7 +147,7 @@
148148 'translate-checks-format' => 'This translation does not follow the definition or has invalid syntax: $1',
149149 'translate-checks-escape' => 'The following escapes may be accidental: <strong>$1</strong>',
150150 'translate-checks-parametersnotequal' => 'Parameter count is {{PLURAL:$1|$1}}; should be {{PLURAL:$2|$2}}.',
151 - 'translate-checks-malformed' => '<nowiki>$1[$2]</nowiki> is malformed.',
 151+ 'translate-checks-malformed' => '<nowiki>$1</nowiki> is malformed.',
152152 'translate-checks-fudforum-syntax' => 'Use <nowiki>$1</nowiki> instead of <nowiki>$2</nowiki> in this project.',
153153
154154 'translate-pref-nonewsletter' => 'Do not send me e-mail newsletters',

Follow-up revisions

RevisionCommit summaryAuthorDate
r112484Fix regression in r111272 addressed in CR of r111825.siebrand13:33, 27 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111272* Move hard coded styles in MessageWebImporter to CSS....siebrand04:45, 12 February 2012
r111821Use numbered variables. Follows-up r111272.siebrand12:10, 18 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   12:58, 27 February 2012

It used to be $traArray[$i], now it is $defArray[$i]. Was that intentional change?

#Comment by Hashar (talk | contribs)   09:59, 29 February 2012

Siebrand said:

> *facepalm*

Can we get a picture or, even better, a video?:-)

Status & tagging log