r111820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111819‎ | r111820 | r111821 >
Date:10:57, 18 February 2012
Author:hashar
Status:reverted
Tags:
Comment:
(bug 34421) avoid duplicate Subject headers in mail

r93397 duplicated the Subject header since it was passed both as an
argument of mail() and in the additional headers array.

This is r111765 done right.

Tested using both Pear and mail() methods.
Modified paths:
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
——@@ -244,6 +244,8 @@
245245 $endl = "\n";
246246 }
247247
 248+ # Subject header is unneeded since it an argument of mail()
 249+ unset( $headers['Subject'] );
248250 $headers = self::arrayToHeaderString( $headers, $endl );
249251
250252 wfDebug( "Sending mail via internal mail() function\n" );

Sign-offs

UserFlagDate
Hashartested10:57, 18 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r111832(bug 34421) duplicate Subject / wrong To: headers in mail...hashar15:34, 18 February 2012
r111925MFT to 1.19wmf1 r111832...hashar13:32, 20 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93397Reduce mail header differences by moving all the header creation code...mah16:56, 28 July 2011
r111765(bug 34421) avoid duplicate Subject headers...hashar17:02, 17 February 2012
r111819revert r111765 bug 34421 avoid duplicate Subject headers...hashar10:37, 18 February 2012

Status & tagging log