r111804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111803‎ | r111804 | r111805 >
Date:00:14, 18 February 2012
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Fix weird bug where CSS was not loaded yet, and it was assumed that it would. Related to bug 34450
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.collapsibleNav.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.collapsibleNav.js
@@ -160,6 +160,7 @@
161161 // Apply a class to the entire panel to activate styles
162162 $( '#mw-panel' ).addClass( 'collapsible-nav' );
163163 // Use cookie data to restore preferences of what to show and hide
 164+ $( '#mw-panel div.body').hide();
164165 $( '#mw-panel > div.portal:not(.persistent)' )
165166 .each( function( i ) {
166167 var id = $(this).attr( 'id' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r111805MFT r111804werdna00:15, 18 February 2012
r111806Follow-up r111804: Accidentally hides the non-collapsed stuffwerdna00:19, 18 February 2012
r111809Add missing dependency of mediawiki.user to mediawiki.api.watch. May resolve ...werdna00:42, 18 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111685CollapsibleNav code wasn't run in a document ready hook. Maybe, just maybe, t...catrope21:30, 16 February 2012

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   00:19, 18 February 2012

Hides stuff it shouldn't... (oops)

Status & tagging log