r111808 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111807‎ | r111808 | r111809 >
Date:00:41, 18 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki.special/mediawiki.special.preferences.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/resources/mediawiki.special/mediawiki.special.preferences.js
@@ -1,7 +1,7 @@
22 /*
33 * JavaScript for Special:Preferences
44 */
5 -( function( $, mw ) {
 5+jQuery( document ).ready( function( $ ) {
66 $( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
77 var $preftoc = $('<ul id="preftoc"></ul>');
88 var $preferences = $( '#preferences' )
@@ -49,14 +49,11 @@
5050
5151 // If we've reloaded the page or followed an open-in-new-window,
5252 // make the selected tab visible.
53 -// On document ready:
54 -$( function() {
55 - var hash = window.location.hash;
56 - if( hash.match( /^#mw-prefsection-[\w-]+/ ) ) {
57 - var $tab = $( hash.replace( 'mw-prefsection', 'preftab' ) );
58 - $tab.click();
59 - }
60 -} );
 53+var hash = window.location.hash;
 54+if( hash.match( /^#mw-prefsection-[\w-]+/ ) ) {
 55+ var $tab = $( hash.replace( 'mw-prefsection', 'preftab' ) );
 56+ $tab.click();
 57+}
6158
6259
6360 /**
@@ -137,4 +134,4 @@
138135 $tzTextbox.blur( function() { updateTimezoneSelection(); } );
139136 updateTimezoneSelection();
140137 }
141 -} )( jQuery, mediaWiki );
\ No newline at end of file
 138+} );
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
142139 Merged /trunk/phase3:r111802-111803

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111802fix for bug 34466 - making sure mediawiki module isnt executed before the DOM...kaldari00:06, 18 February 2012
r111803follow-up to r111802, we dont need internal document.ready trigger since the ...kaldari00:08, 18 February 2012

Status & tagging log