r111803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111802‎ | r111803 | r111804 >
Date:00:08, 18 February 2012
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r111802, we dont need internal document.ready trigger since the entire js file is inside a document.ready trigger now
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js
@@ -49,14 +49,11 @@
5050
5151 // If we've reloaded the page or followed an open-in-new-window,
5252 // make the selected tab visible.
53 -// On document ready:
54 -$( function() {
55 - var hash = window.location.hash;
56 - if( hash.match( /^#mw-prefsection-[\w-]+/ ) ) {
57 - var $tab = $( hash.replace( 'mw-prefsection', 'preftab' ) );
58 - $tab.click();
59 - }
60 -} );
 53+var hash = window.location.hash;
 54+if( hash.match( /^#mw-prefsection-[\w-]+/ ) ) {
 55+ var $tab = $( hash.replace( 'mw-prefsection', 'preftab' ) );
 56+ $tab.click();
 57+}
6158
6259
6360 /**

Sign-offs

UserFlagDate
Nikerabbitinspected09:43, 18 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r111808MFT r111802, r111803aaron00:41, 18 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111802fix for bug 34466 - making sure mediawiki module isnt executed before the DOM...kaldari00:06, 18 February 2012

Status & tagging log