r111806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111805‎ | r111806 | r111807 >
Date:00:19, 18 February 2012
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Follow-up r111804: Accidentally hides the non-collapsed stuff
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.collapsibleNav.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.collapsibleNav.js
@@ -160,7 +160,6 @@
161161 // Apply a class to the entire panel to activate styles
162162 $( '#mw-panel' ).addClass( 'collapsible-nav' );
163163 // Use cookie data to restore preferences of what to show and hide
164 - $( '#mw-panel div.body').hide();
165164 $( '#mw-panel > div.portal:not(.persistent)' )
166165 .each( function( i ) {
167166 var id = $(this).attr( 'id' );
@@ -174,6 +173,7 @@
175174 $(this)
176175 .addClass( 'expanded' )
177176 .find( 'div.body' )
 177+ .hide() // bug 34450
178178 .show();
179179 } else {
180180 $(this).addClass( 'collapsed' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111804Fix weird bug where CSS was not loaded yet, and it was assumed that it would....werdna00:14, 18 February 2012

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   00:23, 18 February 2012

Nobody really liked those links anyways...

Status & tagging log