r111802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111801‎ | r111802 | r111803 >
Date:00:06, 18 February 2012
Author:kaldari
Status:resolved
Tags:
Comment:
fix for bug 34466 - making sure mediawiki module isnt executed before the DOM is ready
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.preferences.js
@@ -1,7 +1,7 @@
22 /*
33 * JavaScript for Special:Preferences
44 */
5 -( function( $, mw ) {
 5+jQuery( document ).ready( function( $ ) {
66 $( '#prefsubmit' ).attr( 'id', 'prefcontrol' );
77 var $preftoc = $('<ul id="preftoc"></ul>');
88 var $preferences = $( '#preferences' )
@@ -137,4 +137,4 @@
138138 $tzTextbox.blur( function() { updateTimezoneSelection(); } );
139139 updateTimezoneSelection();
140140 }
141 -} )( jQuery, mediaWiki );
\ No newline at end of file
 141+} );

Follow-up revisions

RevisionCommit summaryAuthorDate
r111803follow-up to r111802, we dont need internal document.ready trigger since the ...kaldari00:08, 18 February 2012
r111808MFT r111802, r111803aaron00:41, 18 February 2012

Status & tagging log