r111352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111351‎ | r111352 | r111353 >
Date:07:42, 13 February 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Have the radio buttons go with the label, not the line before (CSS has label { nowrap })
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialTranslate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialTranslate.php
@@ -325,21 +325,17 @@
326326 if ( $this->defaults['task'] === $id ) {
327327 return '';
328328 }
329 - return $sep . Xml::radioLabel(
330 - wfMessage( "translate-taskui-$id" )->text(),
331 - 'task', $id, 'task', // Name, value, id
332 - true // Selected
 329+ return $sep . Html::rawElement( 'label', null,
 330+ Xml::radio( 'task', $id, true ) . ' ' .
 331+ wfMessage( "translate-taskui-$id" )->escaped()
333332 );
334333 } else {
335334 $output = '';
336335 foreach ( $tasks as $index => $id ) {
337 - $output .= Xml::radioLabel(
338 - wfMessage( "translate-taskui-$id" )->text(),
339 - 'task', // Name
340 - $id,
341 - "task-$index", // id
342 - $this->options['task'] === $id
343 - );
 336+ $output .= Html::rawElement( 'label', null,
 337+ Xml::radio( 'task', $id, $this->options['task'] === $id ) . ' ' .
 338+ wfMessage( "translate-taskui-$id" )->escaped()
 339+ ) . ' ';
344340 }
345341 return $sep . $output;
346342 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111149I18n#533: Task based UI Special:Translate and better interlinking of statistics...nikerabbit11:53, 10 February 2012

Status & tagging log