r109932 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109931‎ | r109932 | r109933 >
Date:16:25, 24 January 2012
Author:hashar
Status:reverted (Comments)
Tags:design 
Comment:
diff: align cell content to the top

This is needed when both sides are unbalanced. For example when a very
long paragraph is replaced by a single sentence, the text in the right
cell will be floating in the middle.

Example using ?action=render-ascii:

PRE PATCH:
+----------------+ +----------------+
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | lot of e |
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | |
+----------------+ +----------------+

POST PATCH:
+----------------+ +----------------+
|eeeeeeeeeeeeeeee| | lot of e |
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | |
|eeeeeeeeeeeeeeee| | |
+----------------+ +----------------+


Part of: bug 33335 - new color scheme and text display for diffs
follow r107127
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
——@@ -19,6 +19,7 @@
2020 td.diff-deletedline,
2121 td.diff-context {
2222 font-size: 88%;
 23+ vertical-align: top;
2324 white-space: -moz-pre-wrap;
2425 white-space: pre-wrap;
2526 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112750[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it ...krinkle01:07, 1 March 2012
r112836Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884...tparscal21:27, 1 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107127Applying patch from bug 33335 (from Erwin Dokter). Followup to r105280...robla00:22, 23 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:33, 25 January 2012

The bigger problem is that the diff algorithm is bad at matching paragraphs together.

Status & tagging log