r94429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94428‎ | r94429 | r94430 >
Date:20:57, 13 August 2011
Author:maxsem
Status:reverted (Comments)
Tags:
Comment:
(bug 11374) Red .diffchange text in the green 'added' area may be hard to read for colorblind users
This should REALLY REALLY be fixed with colors from French Wikipedia, but since some people think that we should preserve yellow/green colors, I've simply made change text black instead of red, and made its background different for better reading by people with other problems with vision.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
——@@ -27,13 +27,20 @@
2828 font-size: smaller;
2929 }
3030 .diffchange {
31 - color: red;
3231 font-weight: bold;
3332 white-space: -moz-pre-wrap;
3433 white-space: pre-wrap;
3534 text-decoration: none;
3635 }
3736
 37+td.diff-addedline .diffchange {
 38+ background: #0c0;
 39+}
 40+
 41+td.diff-deletedline .diffchange {
 42+ background: #cc0;
 43+}
 44+
3845 table.diff {
3946 border: none;
4047 width: 98%;
Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -46,6 +46,7 @@
4747 instead require() for included extensions.
4848 * Do not convert text in the user interface language to another script.
4949 * (bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages
 50+* (bug 11374) Improved diff readability for colorblind people.
5051
5152 === API changes in 1.19 ===
5253 * (bug 19838) siprop=interwikimap can now use the interwiki cache.

Follow-up revisions

RevisionCommit summaryAuthorDate
r94461Fix r94429 : Left and right side are still nearly the same color for 7% of th...diebuche14:40, 14 August 2011
r105280Diff colors now use the french Wikipedia scheme...hashar09:41, 6 December 2011
r112750[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it ...krinkle01:07, 1 March 2012
r112836Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884...tparscal21:27, 1 March 2012

Comments

#Comment by Hashar (talk | contribs)   11:33, 5 December 2011

This rev is broken but main discussions seems to happen on r94461

#Comment by Brion VIBBER (talk | contribs)   18:24, 6 December 2011

Overridden by r105280, using the French style.

Status & tagging log