r107127 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107126‎ | r107127 | r107128 >
Date:00:22, 23 December 2011
Author:robla
Status:reverted (Comments)
Tags:design 
Comment:
Applying patch from bug 33335 (from Erwin Dokter). Followup to r105280
and r106884.
* td.diff-deletedline gets a softer yellow background
* td.diff-addedline gets a lighter blue background,
* td.diff-context gets slightly lighter grey background.
* Instead of only the changed text being displayed with white-space:pre-wrap,
the entire line in a cell is.
* The font-size is changed from 'smaller' to 88%
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css
——@@ -2,7 +2,6 @@
33 ** Diff rendering
44 */
55 table.diff,
6 -td.diff-context,
76 td.diff-otitle,
87 td.diff-ntitle {
98 background-color: transparent;
——@@ -21,35 +20,37 @@
2221 font-weight: bold;
2322 }
2423
 24+td.diff-addedline,
 25+td.diff-deletedline,
 26+td.diff-context {
 27+ font-size: 88%;
 28+ white-space: -moz-pre-wrap;
 29+ white-space: pre-wrap;
 30+}
 31+
2532 td.diff-addedline {
26 - background: #e0ecff;
 33+ background: #E0ECFF;
2734 }
2835
2936 td.diff-deletedline {
30 - background: #ffffaa;
 37+ background: #FCF8CC;
3138 }
3239
3340 td.diff-context {
34 - background: #EEE;
 41+ background: #F2F2F2;
3542 }
3643
3744 .diffchange {
3845 font-weight: bold;
39 - white-space: -moz-pre-wrap;
40 - white-space: pre-wrap;
4146 text-decoration: none;
4247 }
4348
4449 td.diff-addedline .diffchange {
45 - background: #c4d3ff;
46 - color: #222222;
47 - font-weight: bold;
 50+ background: #B0C8FF;
4851 }
4952
5053 td.diff-deletedline .diffchange {
51 - background: #ffd89d;
52 - color: #000000;
53 - font-weight: bold;
 54+ background: #FFD084;
5455 }
5556
5657 table.diff {

Follow-up revisions

RevisionCommit summaryAuthorDate
r109932diff: align cell content to the top...hashar16:25, 24 January 2012
r112750[mediawiki.action.history.diff.css] Revert 1.19 style changes back to how it ...krinkle01:07, 1 March 2012
r112836Resolves bug #11374 and improves on r94429, r94461, r101147, r105280, r106884...tparscal21:27, 1 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105280Diff colors now use the french Wikipedia scheme...hashar09:41, 6 December 2011
r106884Followup r105280...bharris22:53, 20 December 2011

Comments

#Comment by Edokter (talk | contribs)   17:44, 3 January 2012

Minor follow-up for RELEASE-NOTES-1.19: it still mentions "Colors comes from the French Wikipedia." However, that is no longer the case. Can it be removed?

#Comment by He7d3r (talk | contribs)   16:52, 29 February 2012

See bugzilla:34798

Status & tagging log