r94461 MediaWiki - Code Review archive

Here's a few screenshots:

• 1.17.0 (currently on Wikipedia diffs): http://i.imgur.com/Wei7s.png
• trunk (before this commit): http://i.imgur.com/Ui0gg.png
• trunk (after this commit): http://i.imgur.com/4SZM7.png

Live example: http://peachy.johnduhart.me/w/index.php?title=Main_Page&diff=prev&oldid=501

This is much too dark, in my opinion. I think the color change is fine, but the darker background makes reading the black text more difficult for me.

Has this been confirmed at all with actual users for which this fix was needed ? On that matter, would be a good idea to A/B/C test the above three in general for people, that might uncover other problems with our diff-workflow (ie. find history page, find out how to compare revisions, and interpret the diff).

Suggest revert and confirmation first. Ideally user testing would take place on prototype, but a design that is agreed on on BugZilla pre-commit is good too. On bug 11374, Brandon actually suggested later to use green/blue instead of brown/blue, the commit jumped the gun, discusion wasn't ready yet.

I'd like to see some user testing on this, actually. It's kind of lame that we don't have a test bed for it; can we get this deployed to testwiki and ask people to look at it? I would still like to see green/blue as well.

We can test it ourselves without having to merge & deploy it...just make the changes to testwiki's Common.css.

See reply below with the 3 list items. I did this on prototype for now, showing each in a live diff demo.

test.wikipedia.org isn't meant for that kind of testing. For now prototype is the place to do that sort of testing.

Since these are technically speaking very small changes I created a little environment on the Prototype wiki featuring all three Diff-styles.

http://prototype.wikimedia.org/

• 1) "yellow/green. Changetext is highlighted by being bold and red"
  • This is the current standard and remained unchanged upto and including the 1.17 release.
  • » Example diff for "Amsterdam"
• 2) "yellow/green. Changetext is highlighted by being bold and on a slightly more saturated background"
  • Created by rev:94429, about to be released in 1.18 although we will revert / replace that with whatever we come up with here
  • » Example diff for "Berlin"
• 3) "brown/blue. Changetext is highlighted by being bold and on a darker background with a black border around it"
  • Result of this (rev:94461) revision. Currently the reality for any wiki running live on trunk.
  • » Example diff for "Central"

Personally I think, of these three, the 2nd one is a good candidate. Perhaps use blue on the left instead of yellow. The problem I see with the third option is that it's very crowded and busy and overal too dark (not enough contrast between the darkened background color and the black text and the black border around it.

Is there any progress on this revision?

Since the ILIKEIT arguing isn't going to ever end, I propose to use the only improved coloring scheme widely tested on live humans: the French version. At least in one parameter it's definitely better than DieBuche's: it has lighter .diffchange background making it easier to read.

The french version is probably the best one for the moment. I have been bold and applied the change with r105280.

Marking this revision as reverted since mine basically override all the styles there.

A basic design file has been added as docs/uidesign/mediawiki.action.history.diff.html