r108060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108059‎ | r108060 | r108061 >
Date:18:01, 4 January 2012
Author:mah
Status:reverted
Tags:notmysql 
Comment:
re r106025 — apply follow up from Luca Fulchir
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -645,7 +645,7 @@
646646 $schema = '"' . $dbDetails[0] . '".';
647647 $table = $dbDetails [1];
648648 } else {
649 - $schema = "\"{$wgDBmwschema}\"."; # keep old schema, but quote it.
 649+ $schema = ""; # do NOT force the schema (due to temporary tables)
650650 $table = $dbDetails[0];
651651 }
652652 if ( $format != 'quoted' ) {
@@ -659,11 +659,6 @@
660660 }
661661 }
662662
663 - # during installation wgDBmwschema is not set, so we would end up quering
664 - # ""."table" => error. Erase the first part if wgDBmwschema is empty
665 - if ( $schema == "\"\"." ) {
666 - $schema = "";
667 - }
668663 if ( isset( $wgSharedDB ) # We have a shared database (=> schema)
669664 && isset( $wgSharedTables )
670665 && is_array( $wgSharedTables )

Follow-up revisions

RevisionCommit summaryAuthorDate
r108337No need of $wgDBmwschema after r108060platonides23:29, 7 January 2012
r110690Reverted r106025 and friends (r106370, r106373, r108060, r108337, r106419). T...aaron23:37, 3 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106025Bug 16794 - $wgSharedDB PostgreSQL support...mah15:06, 13 December 2011

Status & tagging log