r106419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106418‎ | r106419 | r106420 >
Date:08:56, 16 December 2011
Author:nikerabbit
Status:reverted (Comments)
Tags:
Comment:
Foooollowup r106373 - update comment
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -639,9 +639,7 @@
640640 if ( preg_match( '/(^|\s)(DISTINCT|JOIN|ON|AS)(\s|$)/i', $name ) !== 0 ) {
641641 return $name;
642642 }
643 - # Split database and table into proper variables.
644 - # We reverse the explode so that schema.table and table both output
645 - # the correct table.
 643+ # Extract the database prefix, if any and quote it
646644 $dbDetails = explode( '.', $name, 2 );
647645 if ( isset( $dbDetails[1] ) ) {
648646 $schema = '"' . $dbDetails[0] . '".';

Follow-up revisions

RevisionCommit summaryAuthorDate
r110690Reverted r106025 and friends (r106370, r106373, r108060, r108337, r106419). T...aaron23:37, 3 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106025Bug 16794 - $wgSharedDB PostgreSQL support...mah15:06, 13 December 2011
r106373Simplify a bit the code of r106025platonides21:21, 15 December 2011

Comments

#Comment by Platonides (talk | contribs)   19:02, 16 December 2011

Good point.

Status & tagging log