r106370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106369‎ | r106370 | r106371 >
Date:21:12, 15 December 2011
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Use the canonical name of the setting
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -624,7 +624,7 @@
625625 }
626626
627627 function tableName( $name, $format = 'quoted' ) {
628 - global $wgSharedDB, $wgSharedTables, $wgDBmwSchema;
 628+ global $wgSharedDB, $wgSharedTables, $wgDBmwschema;
629629 # Skip quoted tablenames.
630630 if ( $this->isQuotedIdentifier( $name ) ) {
631631 return $name;
@@ -659,13 +659,13 @@
660660 }
661661 }
662662 if ( !isset( $schema )) {
663 - $schema = "\"{$wgDBmwSchema}\".";
 663+ $schema = "\"{$wgDBmwschema}\".";
664664 } else {
665665 # keep old schema, but quote it.
666666 $schema = "\"{$schema}\".";
667667 }
668 - # during installation wgDBmwSchema is not set, so we would end up quering
669 - # ""."table" => error. Erase the first part if wgDBmwSchema is empty
 668+ # during installation wgDBmwschema is not set, so we would end up quering
 669+ # ""."table" => error. Erase the first part if wgDBmwschema is empty
670670 if ( $schema == "\"\"." ) {
671671 $schema = "";
672672 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r110690Reverted r106025 and friends (r106370, r106373, r108060, r108337, r106419). T...aaron23:37, 3 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106025Bug 16794 - $wgSharedDB PostgreSQL support...mah15:06, 13 December 2011

Comments

#Comment by OverlordQ (talk | contribs)   17:10, 19 December 2011

For some reason this completely breaks parser testing.

#Comment by OverlordQ (talk | contribs)   18:58, 19 December 2011

Shouldn't all the db calls in tests/parser/parserTest.inc be using $this->dbClone instead of $this->db?

#Comment by Platonides (talk | contribs)   20:56, 19 December 2011

Maybe it was a problem in r106025, working just because it refered to a non-existant variable?

I don't see any missing reference to $wgDBmwSchema.

#Comment by OverlordQ (talk | contribs)   21:00, 19 December 2011

Highly likely.

#Comment by OverlordQ (talk | contribs)   21:20, 19 December 2011

Left comment on parent bug, remarking as new.

Status & tagging log