r108061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108060‎ | r108061 | r108062 >
Date:18:20, 4 January 2012
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r107960 - remove unnecessary language function call and update the timestamp to access database with correct format
Modified paths:
  • /trunk/extensions/MoodBar/SpecialFeedbackDashboard.php (modified) (history)
  • /trunk/extensions/MoodBar/include/MoodBarUtil.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/include/MoodBarUtil.php
@@ -58,8 +58,7 @@
5959 $messageKey = $displayBlock;
6060 }
6161
62 - return wfMessage( $messageKey )->inLanguage( $wgLang )
63 - ->params( $wgLang->formatNum( $displayTime ) )->escaped();
 62+ return wfMessage( $messageKey )->params( $wgLang->formatNum( $displayTime ) )->escaped();
6463
6564 } else {
6665 return wfMessage( 'moodbar-seconds' )->escaped();
Index: trunk/extensions/MoodBar/SpecialFeedbackDashboard.php
@@ -82,7 +82,7 @@
8383 $dbr = wfGetDB( DB_SLAVE );
8484 $res = $dbr->select( array( 'moodbar_feedback' ),
8585 array( 'mbf_type', 'COUNT(*) AS number' ),
86 - array( 'mbf_hidden_state' => 0, 'mbf_timestamp > ' . $dbr->addQuotes( wfTimestamp( TS_MW, $timestamp ) ) ),
 86+ array( 'mbf_hidden_state' => 0, 'mbf_timestamp > ' . $dbr->addQuotes( $dbr->timestamp( $timestamp ) ) ),
8787 __METHOD__,
8888 array( 'GROUP BY' => 'mbf_type' )
8989 );

Sign-offs

UserFlagDate
Nikerabbitinspected06:40, 5 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107960Format feedback dashbaord time display to have only the largest time block, f...bsitu23:35, 3 January 2012

Status & tagging log