r106418 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106417‎ | r106418 | r106419 >
Date:07:56, 16 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/WebFonts/resources/ext.webfonts.js
@@ -278,6 +278,10 @@
279279 mw.webfonts.set( $(this).val() );
280280 } );
281281 for ( var scheme in config ) {
 282+ if ( !Object.prototype.hasOwnProperty.call( config, scheme ) ) {
 283+ continue;
 284+ }
 285+
282286 var $fontLink = $( '<input type="radio" name="font" />' )
283287 .attr( 'id', fontID( config[scheme] ) )
284288 .val( config[scheme] );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106398[WebFonts] Don't loop over an object unfiltered!...krinkle00:02, 16 December 2011

Status & tagging log