r106393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106392‎ | r106393 | r106394 >
Date:23:40, 15 December 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
default deprecation notice limit to 1.17, so 1.18 and 1.19 notices are not shown unless this setting is modified. fullow up to r106070 r105985. see here for motivation: http://lists.wikimedia.org/pipermail/wikitech-l/2011-December/056959.html
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -4066,7 +4066,7 @@
40674067 * development warnings will not be generated for deprecations added in releases
40684068 * after the limit.
40694069 */
4070 -$wgDeprecationReleaseLimit = false;
 4070+$wgDeprecationReleaseLimit = '1.17';
40714071
40724072 /** Only record profiling info for pages that took longer than this */
40734073 $wgProfileLimit = 0.0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r106401follow up to r106393 - re-add these notices, since now they wont show for peo...jeroendedauw00:24, 16 December 2011
r111346Revert r106393; I do not find it acceptible for MediaWiki to ship by-default ...dantman00:35, 13 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105985add missing deprecation notices and added deprecation version to existing onesjeroendedauw05:19, 13 December 2011
r106070added missing deprecation noticesjeroendedauw19:51, 13 December 2011

Comments

#Comment by Bawolff (talk | contribs)   00:27, 13 February 2012

I strongly dislike setting this to something other than false by default. Two reasons

  • People are going to forget to update this (Case in point, we are at 1.20 now. this is still 1.17)
  • People (and by people I mean me) enable development warnings, because we want to see the warnings. It is not useful to show the warnings a year after we decided we deprecated the interface. I want to know the moment we deprecated the interface, because I don't want to make new code that relies on the interface.
#Comment by Jeroen De Dauw (talk | contribs)   00:57, 13 February 2012

Yeah, me as well. I added a ton of notices to methods that where just marked as deprecated but did not actually call wfDepracted yet so I could see warnings. Then people got mad and forced me to either revert or change this. Yay for someone else changing it back. Now I can remove setting this to false in my LocalSettings file and enjoy sanity by default.

#Comment by Bawolff (talk | contribs)   02:02, 13 February 2012

I don't really think things should be marked as deprecated if they still have callers in the extension repo.

Status & tagging log