r106401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106400‎ | r106401 | r106402 >
Date:00:24, 16 December 2011
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
follow up to r106393 - re-add these notices, since now they wont show for people that change the depr limit to see them
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/includes/logging/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2594,7 +2594,7 @@
25952595 * @deprecated since 1.18 Use ->getSkin() in the most relevant outputting context you have
25962596 */
25972597 public function getSkin() {
2598 - //wfDeprecated( __METHOD__, '1.18' );
 2598+ wfDeprecated( __METHOD__, '1.18' );
25992599 return RequestContext::getMain()->getSkin();
26002600 }
26012601
@@ -3186,14 +3186,14 @@
31873187
31883188 /**
31893189 * Alias for getEditToken.
3190 - * @deprecated since 1.19, use getEditToken instead. Warnings in 1.21.
 3190+ * @deprecated since 1.19, use getEditToken instead.
31913191 *
31923192 * @param $salt String|Array of Strings Optional function-specific data for hashing
31933193 * @param $request WebRequest object to use or null to use $wgRequest
31943194 * @return String The new edit token
31953195 */
31963196 public function editToken( $salt = '', $request = null ) {
3197 - # wfDeprecated( __METHOD__, '1.19' );
 3197+ wfDeprecated( __METHOD__, '1.19' );
31983198 return $this->getEditToken( $salt, $request );
31993199 }
32003200
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1153,7 +1153,7 @@
11541154 * @return Language
11551155 */
11561156 function wfUILang() {
1157 - # wfDeprecated( __METHOD__, '1.18' ); // See r105985 and it's revert. Somewhere still used.
 1157+ wfDeprecated( __METHOD__, '1.18' );
11581158 global $wgLang;
11591159 return $wgLang;
11601160 }
Index: trunk/phase3/includes/logging/LogPage.php
@@ -175,7 +175,7 @@
176176 * @deprecated in 1.19, warnings in 1.21. Use getName()
177177 */
178178 public static function logName( $type ) {
179 - # wfDeprecated( __METHOD__, '1.19' );
 179+ wfDeprecated( __METHOD__, '1.19' );
180180 global $wgLogNames;
181181
182182 if( isset( $wgLogNames[$type] ) ) {
@@ -195,7 +195,7 @@
196196 * @deprecated in 1.19, warnings in 1.21. Use getDescription()
197197 */
198198 public static function logHeader( $type ) {
199 - # wfDeprecated( __METHOD__, '1.19' );
 199+ wfDeprecated( __METHOD__, '1.19' );
200200 global $wgLogHeaders;
201201 return wfMsgExt( $wgLogHeaders[$type], array( 'parseinline' ) );
202202 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106393default deprecation notice limit to 1.17, so 1.18 and 1.19 notices are not sh...jeroendedauw23:40, 15 December 2011

Comments

#Comment by Platonides (talk | contribs)   22:46, 7 January 2012

You're (re)marking LogPage::logName() as deprecated, yet per your r106095, it's not that clear how to replace it.

Status & tagging log