r106392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106391‎ | r106392 | r106393 >
Date:23:38, 15 December 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
add hide footer support
Modified paths:
  • /trunk/extensions/MobileFrontend/FooterTemplate.php (modified) (history)
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/FooterTemplate.php
@@ -32,8 +32,10 @@
3333
3434 $feedbackLink = ( $this->data['code'] == 'en' && $this->data['isBetaGroupMember'] ) ? "| <a href=\"{$leaveFeedbackURL}\">{$leaveFeedback}</a>" : '';
3535
 36+ $footerDisplayNone = ( $this->data['hideFooter'] ) ? ' style="display: none;" ' : '';
 37+
3638 $footerHtml = <<<HTML
37 - <div id='footer'>
 39+ <div id='footer' {$footerDisplayNone}>
3840 <div class='nav' id='footmenu'>
3941 <div class='mwm-notice'>
4042 <a href="{$viewNormalSiteURL}">{$regularSite}</a> | <a href="{$imagesURL}">{$imagesToggle}</a> {$feedbackLink} {$logoutLink}
Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -146,6 +146,7 @@
147147 public static $isBetaGroupMember = false;
148148 public static $hideSearchBox = false;
149149 public static $hideLogo = false;
 150+ public static $hideFooter = false;
150151 public static $languageUrls;
151152 public static $wsLoginToken = '';
152153 public static $wsLoginFormAction = '';
@@ -710,6 +711,10 @@
711712 self::$hideLogo = true;
712713 }
713714 }
 715+
 716+ if ( self::$hideLogo && self::$hideLogo == true ) {
 717+ self::$hideFooter = true;
 718+ }
714719
715720 $optInCookie = $this->getOptInOutCookie();
716721 if ( !empty( $optInCookie ) &&
@@ -1576,6 +1581,7 @@
15771582 'logoutHtml' => $logoutHtml,
15781583 'loginHtml' => $loginHtml,
15791584 'code' => self::$code,
 1585+ 'hideFooter' => self::$hideFooter,
15801586 'isBetaGroupMember' => self::$isBetaGroupMember,
15811587 );
15821588 $footerTemplate->setByArray( $options );

Follow-up revisions

RevisionCommit summaryAuthorDate
r106464fix for r106392 and r106391preilly19:15, 16 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   10:27, 16 December 2011
+if ( self::$hideLogo && self::$hideLogo == true ) {
+  self::$hideFooter = true;

Umm??

Status & tagging log