r111346 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111345‎ | r111346 | r111347 >
Date:00:35, 13 February 2012
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Revert r106393; I do not find it acceptible for MediaWiki to ship by-default strangling it's deprecation notices.
Extension authors are supposed to be notified of deprecated code they are using that may disappear. This config variable was added so that devs who had an explicit reason to hide specific ranges of deprecation notices from MediaWiki (as opposed to all MediaWiki deprecation notices, or all php deprecation notices) not as a method of hiding notices that people are supposed to see from everyone.
Any dev who wants to should shoot themselves in the foot, that's their job. It is NOT our job to shoot everyone in the foot because some devs are too lazy to shoot themselves.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -4121,7 +4121,7 @@
41224122 * development warnings will not be generated for deprecations added in releases
41234123 * after the limit.
41244124 */
4125 -$wgDeprecationReleaseLimit = '1.17';
 4125+$wgDeprecationReleaseLimit = false;
41264126
41274127 /** Only record profiling info for pages that took longer than this */
41284128 $wgProfileLimit = 0.0;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106393default deprecation notice limit to 1.17, so 1.18 and 1.19 notices are not sh...jeroendedauw23:40, 15 December 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   00:51, 13 February 2012

I fully agree :) Lot's of people that don't though.

#Comment by SVG (talk | contribs)   10:07, 13 February 2012

Support!

Status & tagging log