r106062 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r106061‎ \| r106062 \| r106063 >
Date:	18:47, 13 December 2011
Author:	neilk
Status:	resolved
Tags:
Comment:	merging extensions/VisualEditor. to support 'feedback' and other features also merging these changes, which mostly add API and other libraries to core. MFT r105630, r105646, r105918, r105954, r105963, r105970, r105974, r106003, r106059 and extensions/UploadWizard, since libraries were moved from there into core, and we can't register libs twice.
Modified paths:	/branches/wmf/1.18wmf1/extensions/UploadWizard (added) (history) /branches/wmf/1.18wmf1/extensions/UploadWizard/resources/mw.LanguageUpWiz.js (modified) (history) /branches/wmf/1.18wmf1/extensions/UploadWizard/resources/mw.UploadWizardDeed.js (modified) (history) /branches/wmf/1.18wmf1/extensions/VisualEditor (added) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesAf.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesAr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesAst.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesAz.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesBe_tarask.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesBg.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesBn.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesBr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesBs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesCa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesCs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesCy.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesDa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesDe.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEn.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEo.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEt.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesEu.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesFa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesFi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesFr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesFrp.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesGl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesGrc.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesGsw.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesHe.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesHi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesHr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesHsb.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesHu.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesIa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesId.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesIs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesIt.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesJa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesKa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesKo.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesKsh.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesKu_latn.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesLb.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesLi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesLt.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesMk.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesMl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesMr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesMs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesMzn.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesNl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesNn.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesNo.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesOr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPdc.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPms.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPnb.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPs.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPt.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesPt_br.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesQqq.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesRo.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesRoa_tara.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesRu.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesRue.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesSi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesSl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesSr_ec.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesSv.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesTa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesTe.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesTl.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesTr.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesUk.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesVi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesWa.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesYi.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesYo.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesZh_hans.php (modified) (history) /branches/wmf/1.18wmf1/languages/messages/MessagesZh_hant.php (modified) (history) /branches/wmf/1.18wmf1/maintenance/language/messages.inc (modified) (history) /branches/wmf/1.18wmf1/resources/Resources.php (modified) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.api.category.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.api.edit.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.api.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.api.parse.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.api.titleblacklist.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.feedback.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.jqueryMsg.js (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.jqueryMsg.peg (added) (history) /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.js (modified) (history) /branches/wmf/1.18wmf1/tests/jasmine/spec/mediawiki.jqueryMsg.spec.data.js (added) (history) /branches/wmf/1.18wmf1/tests/jasmine/spec/mediawiki.jqueryMsg.spec.js (added) (history) /branches/wmf/1.18wmf1/tests/jasmine/spec_makers/makeJqueryMsgSpec.php (added) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r106176	r106062: Enabled on WMF cluster for sandbox on mediawiki.org	raymond	12:00, 14 December 2011
r106921	Copy in mediawiki.debug.js/css added to Resources.php in r106062	reedy	02:07, 21 December 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r105630	add guaranteed-to-be-undefined undefined to mw object	neilk	00:29, 9 December 2011
r105646	add JS api, feedback libs from UW into core.	neilk	04:48, 9 December 2011
r105918	fix bug #32979 gM() -> mw.msg()	neilk	19:18, 12 December 2011
r105954	feedback - move messages, etc from uploadwizard to core	neilk	23:15, 12 December 2011
r105963	Add new message keys to go with r105954	reedy	01:10, 13 December 2011
r105970	add jquery messages to core, config mediawiki.feedback to use it correctly	neilk	02:44, 13 December 2011
r105974	moved language library to core mediawiki.jqueryMsg	neilk	03:03, 13 December 2011
r106003	change args for feedback and api -- all optional, in array.	neilk	10:26, 13 December 2011
r106059	reverting r105766, does not work, also too hacky	neilk	18:41, 13 December 2011

Status & tagging log

15:54, 24 December 2011 Reedy (talk | contribs) changed the status of r106062 [removed: new added: resolved]