r105970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105969‎ | r105970 | r105971 >
Date:02:44, 13 December 2011
Author:neilk
Status:ok (Comments)
Tags:
Comment:
add jquery messages to core, config mediawiki.feedback to use it correctly
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
@@ -533,7 +533,9 @@
534534 'scripts' => 'resources/mediawiki/mediawiki.feedback.js',
535535 'dependencies' => array(
536536 'mediawiki.api.edit',
537 - 'mediawiki.Title'
 537+ 'mediawiki.Title',
 538+ 'mediawiki.jqueryMsg',
 539+ 'jquery.ui.dialog',
538540 ),
539541 'messages' => array(
540542 'feedback-note',
@@ -673,6 +675,11 @@
674676 ),
675677 ),
676678
 679+ 'mediawiki.jqueryMsg' => array(
 680+ 'dependencies' => array( 'mediawiki.language', 'mediawiki.util' ),
 681+ 'scripts' => 'resources/mediawiki/mediawiki.jqueryMsg.js'
 682+ ),
 683+
677684 /* MediaWiki Libs */
678685
679686 'mediawiki.libs.jpegmeta' => array(
Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
@@ -52,8 +52,8 @@
5353
5454 // Set up buttons for dialog box. We have to do it the hard way since the json keys are localized
5555 _this.buttons = {};
56 - _this.buttons[ mw.msg( 'mwe-upwiz-feedback-cancel' ) ] = function() { _this.cancel(); };
57 - _this.buttons[ mw.msg( 'mwe-upwiz-feedback-submit' ) ] = function() { _this.submit(); };
 56+ _this.buttons[ mw.msg( 'feedback-cancel' ) ] = function() { _this.cancel(); };
 57+ _this.buttons[ mw.msg( 'feedback-submit' ) ] = function() { _this.submit(); };
5858
5959 var $feedbackPageLink = $j( '<a></a>' ).attr( { 'href': _this.feedbackTitle.getUrl(), 'target': '_blank' } );
6060 this.$dialog =
@@ -65,18 +65,18 @@
6666 $feedbackPageLink )
6767 ),
6868 $( '<div style="margin-top:1em;"></div>' ).append(
69 - mw.msg( 'mwe-upwiz-feedback-subject' ),
 69+ mw.msg( 'feedback-subject' ),
7070 $( '<br/>' ),
7171 $( '<input type="text" class="feedback-subject" name="subject" maxlength="60" style="width:99%;"/>' )
7272 ),
7373 $( '<div style="margin-top:0.4em;"></div>' ).append(
74 - mw.msg( 'mwe-upwiz-feedback-message' ),
 74+ mw.msg( 'feedback-message' ),
7575 $( '<br/>' ),
7676 $( '<textarea name="message" class="feedback-message" style="width:99%;" rows="5" cols="60"></textarea>' )
7777 )
7878 ),
79 - $( '<div class="mwe-upwiz-feedback-mode mwe-upwiz-feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
80 - mw.msg( 'mwe-upwiz-feedback-adding' ),
 79+ $( '<div class="feedback-mode feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
 80+ mw.msg( 'feedback-adding' ),
8181 $( '<br/>' ),
8282 $( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
8383 ),
@@ -87,7 +87,7 @@
8888 ).dialog({
8989 width: 500,
9090 autoOpen: false,
91 - title: mw.msg( 'mwe-upwiz-feedback-title' ),
 91+ title: mw.msg( this.dialogTitleMessageKey ),
9292 modal: true,
9393 buttons: _this.buttons
9494 });

Follow-up revisions

RevisionCommit summaryAuthorDate
r105974moved language library to core mediawiki.jqueryMsgneilk03:03, 13 December 2011
r106062merging extensions/VisualEditor....neilk18:47, 13 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:55, 13 December 2011

Looks like you forgot to svn add new files.

#Comment by NeilK (talk | contribs)   07:11, 13 December 2011

I screwed up here... actually I'm posting from a half-svn half-git world right now. I decided to get rid of the svn part because I was getting things out of sync.

the followup r105974 should make this work.

Status & tagging log