r105766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105765‎ | r105766 | r105767 >
Date:17:45, 10 December 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js
@@ -89,13 +89,18 @@
9090 },
9191
9292 getLicenseWikiText: function() {
 93+ var wikiText;
 94+ // TODO: not nice to have 2 cases here and then have to insert the attribution field...
 95+
9396 if ( _this.showCustomDiv && this.licenseInput.getWikiText() !== '' ) {
94 - return this.licenseInput.getWikiText();
 97+ wikiText = this.licenseInput.getWikiText();
9598 }
9699 else {
97 - return '{{' + mw.UploadWizard.config.licensesOwnWork.filterTemplate
 100+ wikiText = '{{' + mw.UploadWizard.config.licensesOwnWork.filterTemplate
98101 + '|' + mw.UploadWizard.config.licensesOwnWork.defaults[0] + '}}';
99102 }
 103+
 104+ return wikiText.slice( 0, -2 ) + '|attribution=' + this.getAuthorWikiText() + wikiText.slice( -2 );
100105 },
101106
102107 getSourceWikiText: function() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r106059reverting r105766, does not work, also too hackyneilk18:41, 13 December 2011

Comments

#Comment by NeilK (talk | contribs)   18:38, 13 December 2011

This doesn't even work -- I get things like this:

  {{self|cc-by-sa-3.0}|attribution=NeilK}

reverting for now as we are doing some deploys.

#Comment by NeilK (talk | contribs)   18:41, 13 December 2011

reverted in r106059

Status & tagging log