r105918 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105917‎ | r105918 | r105919 >
Date:19:18, 12 December 2011
Author:neilk
Status:ok
Tags:
Comment:
fix bug #32979 gM() -> mw.msg()
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.feedback.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.feedback.js
@@ -19,8 +19,8 @@
2020
2121 // Set up buttons for dialog box. We have to do it the hard way since the json keys are localized
2222 _this.buttons = {};
23 - _this.buttons[ gM( 'mwe-upwiz-feedback-cancel' ) ] = function() { _this.cancel(); };
24 - _this.buttons[ gM( 'mwe-upwiz-feedback-submit' ) ] = function() { _this.submit(); };
 23+ _this.buttons[ mw.msg( 'mwe-upwiz-feedback-cancel' ) ] = function() { _this.cancel(); };
 24+ _this.buttons[ mw.msg( 'mwe-upwiz-feedback-submit' ) ] = function() { _this.submit(); };
2525
2626 var $feedbackPageLink = $j( '<a></a>' ).attr( { 'href': _this.feedbackTitle.getUrl(), 'target': '_blank' } );
2727 this.$dialog =
@@ -32,18 +32,18 @@
3333 $feedbackPageLink )
3434 ),
3535 $( '<div style="margin-top:1em;"></div>' ).append(
36 - gM( 'mwe-upwiz-feedback-subject' ),
 36+ mw.msg( 'mwe-upwiz-feedback-subject' ),
3737 $( '<br/>' ),
3838 $( '<input type="text" class="mwe-upwiz-feedback-subject" name="subject" maxlength="60" style="width:99%;"/>' )
3939 ),
4040 $( '<div style="margin-top:0.4em;"></div>' ).append(
41 - gM( 'mwe-upwiz-feedback-message' ),
 41+ mw.msg( 'mwe-upwiz-feedback-message' ),
4242 $( '<br/>' ),
4343 $( '<textarea name="message" class="mwe-upwiz-feedback-message" style="width:99%;" rows="5" cols="60"></textarea>' )
4444 )
4545 ),
4646 $( '<div class="mwe-upwiz-feedback-mode mwe-upwiz-feedback-submitting" style="text-align:center;margin:3em 0;"></div>' ).append(
47 - gM( 'mwe-upwiz-feedback-adding' ),
 47+ mw.msg( 'mwe-upwiz-feedback-adding' ),
4848 $( '<br/>' ),
4949 $( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' )
5050 ),
@@ -54,7 +54,7 @@
5555 ).dialog({
5656 width: 500,
5757 autoOpen: false,
58 - title: gM( 'mwe-upwiz-feedback-title' ),
 58+ title: mw.msg( 'mwe-upwiz-feedback-title' ),
5959 modal: true,
6060 buttons: _this.buttons
6161 });

Follow-up revisions

RevisionCommit summaryAuthorDate
r106062merging extensions/VisualEditor....neilk18:47, 13 December 2011

Status & tagging log