r104489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104488‎ | r104489 | r104490 >
Date:21:08, 28 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/CentralAuth (modified) (history)
  • /branches/REL1_18/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)
  • /branches/REL1_18/extensions/SecurePoll/includes/entities/Election.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/CentralAuth/specials/SpecialCentralAuth.php
@@ -464,7 +464,7 @@
465465 }
466466 }
467467
468 - $url = $wiki->getUrl( $title );
 468+ $url = $wiki->getFullUrl( $title );
469469 if ( $params )
470470 $url .= '?' . $params;
471471 return Xml::element( 'a',
Property changes on: branches/REL1_18/extensions/CentralAuth
___________________________________________________________________
Modified: svn:mergeinfo
472472 Merged /trunk/extensions/CentralAuth:r104337,104360
Index: branches/REL1_18/extensions/SecurePoll/includes/entities/Election.php
@@ -192,7 +192,7 @@
193193 $notCentrallyBlocked = $this->getProperty( 'not-centrally-blocked' );
194194 $centralBlockCount = isset( $props['central-block-count'] ) ? $props['central-block-count'] : 0;
195195 $centralBlockThreshold = $this->getProperty( 'central-block-threshold', 1 );
196 - if ( $centralBlockCount >= $centralBlockThreshold ) {
 196+ if ( $notCentrallyBlocked && $centralBlockCount >= $centralBlockThreshold ) {
197197 $status->fatal( 'securepoll-blocked-centrally', $wgLang->formatNum( $centralBlockThreshold ) );
198198 }
199199
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
200200 Merged /trunk/extensions:r104337,104360

Follow-up revisions

RevisionCommit summaryAuthorDate
r111157Partial revert r104489 to revert r104337 out of 1.18...reedy14:17, 10 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104337Change getUrl to getFullUrl (due to r98745), so it uses protocol-relative URLsrobin15:04, 27 November 2011
r104360Follow-up r89020 - the election option to enable checking for blocks on other...happy-melon20:10, 27 November 2011

Status & tagging log