r104360 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104359‎ | r104360 | r104361 >
Date:20:10, 27 November 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r89020 - the election option to enable checking for blocks on other wikis (default false) was never actually checked, so the feature was always enabled.
Modified paths:
  • /trunk/extensions/SecurePoll/includes/entities/Election.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SecurePoll/includes/entities/Election.php
@@ -194,7 +194,7 @@
195195 $notCentrallyBlocked = $this->getProperty( 'not-centrally-blocked' );
196196 $centralBlockCount = isset( $props['central-block-count'] ) ? $props['central-block-count'] : 0;
197197 $centralBlockThreshold = $this->getProperty( 'central-block-threshold', 1 );
198 - if ( $centralBlockCount >= $centralBlockThreshold ) {
 198+ if ( $notCentrallyBlocked && $centralBlockCount >= $centralBlockThreshold ) {
199199 $status->fatal( 'securepoll-blocked-centrally', $wgLang->formatNum( $centralBlockThreshold ) );
200200 }
201201

Follow-up revisions

RevisionCommit summaryAuthorDate
r104365MFT r104360reedy21:16, 27 November 2011
r104489MFT r104337, r104360reedy21:08, 28 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89020Add support for detecting number of wikis a user is blocked on, and preventin...werdna07:23, 28 May 2011

Status & tagging log