r104337 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104336‎ | r104337 | r104338 >
Date:15:04, 27 November 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Change getUrl to getFullUrl (due to r98745), so it uses protocol-relative URLs
Modified paths:
  • /trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php
——@@ -532,7 +532,7 @@
533533 }
534534 }
535535
536 - $url = $wiki->getUrl( $title );
 536+ $url = $wiki->getFullUrl( $title );
537537 if ( $params ) {
538538 $url .= '?' . $params;
539539 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r104489MFT r104337, r104360reedy21:08, 28 November 2011
r104490MFT r104337reedy21:09, 28 November 2011
r111157Partial revert r104489 to revert r104337 out of 1.18...reedy14:17, 10 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98745(bug 31320) CentralAuth uses http URLs for autologin images when logging in o...catrope10:27, 3 October 2011

Comments

#Comment by Platonides (talk | contribs)   17:15, 27 November 2011

Bug 25168: Give secure links in CentralAuth when securely logged-in getUrl() is -since r98745- an alias to getCanonicalUrl(), as we want the protocol-relative url, we need to use the new getFullUrl()

Status & tagging log