r104488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104487‎ | r104488 | r104489 >
Date:21:06, 28 November 2011
Author:aaron
Status:deferred
Tags:
Comment:
MFT 104083-104485
Modified paths:
  • /branches/FileBackend/phase3/CREDITS (modified) (history)
  • /branches/FileBackend/phase3/README (modified) (history)
  • /branches/FileBackend/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/FileBackend/phase3/docs/hooks.txt (modified) (history)
  • /branches/FileBackend/phase3/docs/html (modified) (history)
  • /branches/FileBackend/phase3/img_auth.php (modified) (history)
  • /branches/FileBackend/phase3/includes/Action.php (modified) (history)
  • /branches/FileBackend/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/FileBackend/phase3/includes/ChangesList.php (modified) (history)
  • /branches/FileBackend/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/FileBackend/phase3/includes/Export.php (modified) (history)
  • /branches/FileBackend/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/FileBackend/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/FileBackend/phase3/includes/OutputPage.php (modified) (history)
  • /branches/FileBackend/phase3/includes/Pager.php (modified) (history)
  • /branches/FileBackend/phase3/includes/PathRouter.php (added) (history)
  • /branches/FileBackend/phase3/includes/Skin.php (modified) (history)
  • /branches/FileBackend/phase3/includes/SkinTemplate.php (modified) (history)
  • /branches/FileBackend/phase3/includes/UserMailer.php (modified) (history)
  • /branches/FileBackend/phase3/includes/WebRequest.php (modified) (history)
  • /branches/FileBackend/phase3/includes/WikiFilePage.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiBase.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiBlock.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiDelete.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiEditPage.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiEmailUser.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiExpandTemplates.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiFeedWatchlist.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiFormatBase.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiHelp.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiImport.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiLogin.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiLogout.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiMain.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiMove.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiOpenSearch.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiParamInfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiParse.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiPatrol.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiProtect.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiPurge.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQuery.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllCategories.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllLinks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllimages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllmessages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryAllpages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryBlocks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryCategories.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryCategoryInfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryDuplicateFiles.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryExtLinksUsage.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryExternalLinks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryImages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryLinks.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryPageProps.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryProtectedTitles.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryRevisions.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQuerySearch.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryUserInfo.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryUsers.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiRollback.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiRsd.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiUnblock.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiUndelete.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiUpload.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiUserrights.php (modified) (history)
  • /branches/FileBackend/phase3/includes/api/ApiWatch.php (modified) (history)
  • /branches/FileBackend/phase3/includes/db/Database.php (modified) (history)
  • /branches/FileBackend/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /branches/FileBackend/phase3/includes/filerepo/file/File.php (modified) (history)
  • /branches/FileBackend/phase3/includes/filerepo/file/ForeignAPIFile.php (modified) (history)
  • /branches/FileBackend/phase3/includes/filerepo/file/LocalFile.php (modified) (history)
  • /branches/FileBackend/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/FileBackend/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /branches/FileBackend/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /branches/FileBackend/phase3/includes/media/Bitmap.php (modified) (history)
  • /branches/FileBackend/phase3/includes/media/Generic.php (modified) (history)
  • /branches/FileBackend/phase3/includes/mime.info (modified) (history)
  • /branches/FileBackend/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialActiveusers.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialAllmessages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialBlockList.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialCategories.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialLinkSearch.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialListfiles.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialListusers.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialLog.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialNewimages.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialPasswordReset.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/FileBackend/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /branches/FileBackend/phase3/languages/Language.php (modified) (history)
  • /branches/FileBackend/phase3/languages/LanguageConverter.php (modified) (history)
  • /branches/FileBackend/phase3/languages/classes/LanguageSr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesArc.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesArn.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesAs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesAst.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesBar.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesBe_tarask.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesBn.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesCkb.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesCs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesCy.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesDsb.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesEu.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesFr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesFrp.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesFrr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesGan_hant.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesGl.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesGu.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesGv.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesHe.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesHi.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesHr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesHsb.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesHu.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesIa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesIlo.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesIs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesJa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesKa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesKk_cyrl.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesKn.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesKo.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesLb.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesLez.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesLv.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesMai.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesMl.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesMr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesMs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesNan.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesNl.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesNn.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesOr.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesOs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPa.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPms.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPrg.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPs.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesRo.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesRoa_tara.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesRu.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesRue.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesSah.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesSh.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesSq.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesSv.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesUk.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesVep.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesVi.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesXmf.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesYi.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesZh_hans.php (modified) (history)
  • /branches/FileBackend/phase3/languages/messages/MessagesZh_hant.php (modified) (history)
  • /branches/FileBackend/phase3/maintenance/dev (modified) (history)
  • /branches/FileBackend/phase3/maintenance/dev/router.php (modified) (history)
  • /branches/FileBackend/phase3/maintenance/doMaintenance.php (modified) (history)
  • /branches/FileBackend/phase3/maintenance/language/messages.inc (modified) (history)
  • /branches/FileBackend/phase3/maintenance/mwdocgen.php (modified) (history)
  • /branches/FileBackend/phase3/skins/common/shared.css (modified) (history)
  • /branches/FileBackend/phase3/skins/simple/main.css (modified) (history)
  • /branches/FileBackend/phase3/tests/parser/parserTests.txt (modified) (history)
  • /branches/FileBackend/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php (modified) (history)
  • /branches/FileBackend/phase3/tests/phpunit/includes/PathRouterTest.php (added) (history)
  • /branches/FileBackend/phase3/tests/phpunit/includes/TemplateCategoriesTest.php (added) (history)
  • /branches/FileBackend/phase3/tests/phpunit/includes/TitleMethodsTest.php (modified) (history)

Status & tagging log