r104088 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104087‎ | r104088 | r104089 >
Date:21:28, 23 November 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
symlink frontend to presentation

Created symlink in php-1.18/extensions/FlaggedRevs. That most probably
fix the localisation update script.
Translatewiki uses trunk for which 'presentation' was moved to
'frontend'.

See r102741
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/frontend (added) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/frontend
——@@ -0,0 +1 @@
 2+link presentation
\ No newline at end of file
Property changes on: branches/wmf/1.18wmf1/extensions/FlaggedRevs/frontend
___________________________________________________________________
Added: svn:special
13 + *

Sign-offs

UserFlagDate
Hasharinspected21:35, 23 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r108888Revert r104088reedy01:37, 14 January 2012
r108890Do a copy of r104088 into trunk, pointing "presentation" to the frontend folder...reedy02:13, 14 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102741* Renamed dataclasses/ dir to backend/...aaron03:00, 11 November 2011

Comments

#Comment by Hashar (talk | contribs)   21:35, 23 November 2011

Thanks Reedy!

#Comment by Siebrand (talk | contribs)   12:37, 28 December 2011

Can you confirm this *really* fixed it? Also see translatewiki:Thread:Support/LocalisationUpdate_not_working?/reply_(2)

I think this may have to be a fixme...

#Comment by Reedy (talk | contribs)   14:06, 28 December 2011

It did at the time... I seem to remember LU display errors over it, and someone was suggesting it was broken

#Comment by Siebrand (talk | contribs)   14:10, 2 January 2012

Does not work for FlaggedRevs:

Proof that LU is working (from the same commit):

#Comment by Siebrand (talk | contribs)   14:13, 2 January 2012

Damn URLs.

#Comment by Reedy (talk | contribs)   16:15, 2 January 2012

Per the bug for this, which is probably a more sane discussion place, as reverting this definitely wont fix it... Push a more trunk esk version of flagged revs into 1.18wmf1. If that doesn't fix it, we've got bigger issues, as trunk and 1.18wmf1 will at least be in sync then

#Comment by Duplicatebug (talk | contribs)   16:54, 2 January 2012

This symlink is in the wrong branch/in the wrong way. LocalisationUpdate running with this branch is asking again the trunk with the filename FlaggedRevs\presentation\language\FlaggedRevs.i18n.php and under that path is nothing. You have to add that symlink to trunk. 

$langDir = $dir . 'presentation/language/';
$wgExtensionMessagesFiles['FlaggedRevs'] = $langDir . 'FlaggedRevs.i18n.php';
#Comment by Reedy (talk | contribs)   01:54, 14 January 2012 
PHP Warning:  file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ConfiguredPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

Warning: file_get_contents(/var/lib/l10nupdate/trunk/extensions/FlaggedRevs/presentation/language/ConfiguredPages.i18n.php): failed to open stream: No such file or directory in /home/wikipedia/common/php-1.18/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 301

I'd concur. Someone from ops has just created the symlink in trunk in the l10nupdate checkout

Should be able to see in 10-15 minutes...

Status & tagging log