r104089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104088‎ | r104089 | r104090 >
Date:21:29, 23 November 2011
Author:khorn
Status:ok
Tags:
Comment:
Missing a curly brace, all the way back from r101785. This explains why the session wasn't being unset on pre-process transaction rejection.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -1878,13 +1878,13 @@
18791879 if ( $this->getValidationAction() == 'challenge' ) {
18801880 // expose a hook for external handling of trxns flagged for challenge (eg captcha)
18811881 wfRunHooks( 'GatewayChallenge', array( &$this ) );
 1882+ }
18821883
1883 - // if the transaction was flagged for rejection
1884 - if ( $this->getValidationAction() == 'reject' ) {
1885 - // expose a hook for external handling of trxns flagged for rejection
1886 - wfRunHooks( 'GatewayReject', array( &$this ) );
1887 - $this->unsetAllSessionData();
1888 - }
 1884+ // if the transaction was flagged for rejection
 1885+ if ( $this->getValidationAction() == 'reject' ) {
 1886+ // expose a hook for external handling of trxns flagged for rejection
 1887+ wfRunHooks( 'GatewayReject', array( &$this ) );
 1888+ $this->unsetAllSessionData();
18891889 }
18901890 }
18911891

Follow-up revisions

RevisionCommit summaryAuthorDate
r104092MFT r104002, r104089khorn21:57, 23 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101785Lots going on here, in preparation for re-designing the way we validate and a...khorn04:15, 3 November 2011

Status & tagging log