r104087 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104086‎ | r104087 | r104088 >
Date:21:03, 23 November 2011
Author:aaron
Status:ok
Tags:
Comment:
Reverted 'lockTimeout' option from r104069: table_lock_wait_timeout is GLOBAL and the other one requires an innoDB plugin...so that was useless.
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -608,11 +608,6 @@
609609 $this->query( "SET net_read_timeout=$timeout" );
610610 $this->query( "SET net_write_timeout=$timeout" );
611611 }
612 - if ( isset( $options['lockTimeout'] ) ) {
613 - $timeout = (int)$options['lockTimeout'];
614 - $this->query( "SET table_lock_wait_timeout=$timeout" ); // table level
615 - $this->query( "SET innodb_lock_wait_timeout=$timeout" ); // row level
616 - }
617612 }
618613
619614 public function lock( $lockName, $method, $timeout = 5 ) {
Index: trunk/phase3/includes/db/Database.php
@@ -3010,7 +3010,6 @@
30113011 * May be useful for very long batch queries such as
30123012 * full-wiki dumps, where a single query reads out over
30133013 * hours or days.
3014 - * 'lockTimeout' : Set the lock wait timeout value in seconds.
30153014 *
30163015 * @param $options Array
30173016 * @return void

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104069Factored setTimeout() into setSessionOptions() and deprecated the former. In ...aaron19:25, 23 November 2011

Status & tagging log