r103687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103686‎ | r103687 | r103688 >
Date:16:31, 19 November 2011
Author:hashar
Status:reverted
Tags:
Comment:
closing a store is only available for CDB type

follow up r103684
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -358,7 +358,10 @@
359359 $deps = $this->store->get( $code, 'deps' );
360360 $keys = $this->store->get( $code, 'list', 'messages' );
361361 $preload = $this->store->get( $code, 'preload' );
362 - $this->store->close( $code );
 362+ if( $this->store instanceof LCStore_CDB ) {
 363+ // Dont leave open filehandler behind after being called
 364+ $this->store->close( $code );
 365+ }
363366 // Different keys may expire separately, at least in LCStore_Accel
364367 if ( $deps === null || $keys === null || $preload === null ) {
365368 wfDebug( __METHOD__."($code): cache missing, need to make one\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103689revert r103694 r103687...hashar17:00, 19 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103684add possibility to close a LCStore_CDB...hashar16:23, 19 November 2011

Status & tagging log