r103689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103688‎ | r103689 | r103690 >
Date:17:00, 19 November 2011
Author:hashar
Status:ok
Tags:
Comment:
revert r103694 r103687

Need to find a better way to fix that cache issue :(
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -358,10 +358,6 @@
359359 $deps = $this->store->get( $code, 'deps' );
360360 $keys = $this->store->get( $code, 'list', 'messages' );
361361 $preload = $this->store->get( $code, 'preload' );
362 - if( $this->store instanceof LCStore_CDB ) {
363 - // Dont leave open filehandler behind after being called
364 - $this->store->close( $code );
365 - }
366362 // Different keys may expire separately, at least in LCStore_Accel
367363 if ( $deps === null || $keys === null || $preload === null ) {
368364 wfDebug( __METHOD__."($code): cache missing, need to make one\n" );
@@ -1036,13 +1032,6 @@
10371033 }
10381034 }
10391035
1040 - public function close( $code ) {
1041 - if ( !isset( $this->readers[$code] ) ) {
1042 - return;
1043 - }
1044 - $this->readers[$code]->close();
1045 - }
1046 -
10471036 public function startWrite( $code ) {
10481037 if ( !file_exists( $this->directory ) ) {
10491038 if ( !wfMkdirParents( $this->directory, null, __METHOD__ ) ) {
@@ -1197,4 +1186,4 @@
11981187 $this->unload( $code );
11991188 }
12001189 }
1201 -}
 1190+}
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103687closing a store is only available for CDB type...hashar16:31, 19 November 2011

Status & tagging log