r103688 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103687‎ | r103688 | r103689 >
Date:16:40, 19 November 2011
Author:hashar
Status:ok
Tags:
Comment:
Bug 32238 - phaseout wgEnableTooltipsAndAccesskeys
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -23,6 +23,7 @@
2424 * Introduced $wgQueryPageDefaultLimit (defaults to 50) for the number of
2525 items to show by default on query pages (special pages such as Whatlinkshere).
2626 * (bug 32470) Increase the length of ug_group
 27+* (bug 32239) Removed wgEnableTooltipsAndAccesskeys
2728
2829 === New features in 1.19 ===
2930 * (bug 19838) Possibility to get all interwiki prefixes if the interwiki
Index: trunk/phase3/includes/Linker.php
@@ -1713,10 +1713,6 @@
17141714 * escape), or false for no title attribute
17151715 */
17161716 public static function titleAttrib( $name, $options = null ) {
1717 - global $wgEnableTooltipsAndAccesskeys;
1718 - if ( !$wgEnableTooltipsAndAccesskeys )
1719 - return false;
1720 -
17211717 wfProfileIn( __METHOD__ );
17221718
17231719 $message = wfMessage( "tooltip-$name" );
@@ -2006,9 +2002,6 @@
20072003 * Returns the attributes for the tooltip and access key.
20082004 */
20092005 public static function tooltipAndAccesskeyAttribs( $name ) {
2010 - global $wgEnableTooltipsAndAccesskeys;
2011 - if ( !$wgEnableTooltipsAndAccesskeys )
2012 - return array();
20132006 # @todo FIXME: If Sanitizer::expandAttributes() treated "false" as "output
20142007 # no attribute" instead of "output '' as value for attribute", this
20152008 # would be three lines.
@@ -2030,9 +2023,6 @@
20312024 * Returns raw bits of HTML, use titleAttrib()
20322025 */
20332026 public static function tooltip( $name, $options = null ) {
2034 - global $wgEnableTooltipsAndAccesskeys;
2035 - if ( !$wgEnableTooltipsAndAccesskeys )
2036 - return '';
20372027 # @todo FIXME: If Sanitizer::expandAttributes() treated "false" as "output
20382028 # no attribute" instead of "output '' as value for attribute", this
20392029 # would be two lines.
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2345,13 +2345,6 @@
23462346 $wgUseSiteCss = true;
23472347
23482348 /**
2349 - * Set to false to disable application of access keys and tooltips,
2350 - * eg to avoid keyboard conflicts with system keys or as a low-level
2351 - * optimization.
2352 - */
2353 -$wgEnableTooltipsAndAccesskeys = true;
2354 -
2355 -/**
23562349 * Break out of framesets. This can be used to prevent clickjacking attacks,
23572350 * or to prevent external sites from framing your site with ads.
23582351 */

Status & tagging log