r103456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103455‎ | r103456 | r103457 >
Date:12:37, 17 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r101461: per CR, move the code detecting IE7 and below to ext.articleFeedback.startup.js
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -3,12 +3,6 @@
44 */
55
66 ( function( $ ) {
7 -// HACK: This code is broken in IE7 and below, so if this is IE < 8, bail now
8 -var browser = $.client.profile();
9 -if ( browser.name === 'msie' && browser.versionNumber < 8 ) {
10 - return;
11 -}
12 -
137 // Only track users who have been assigned to the tracking group
148 var tracked = 'track' === mw.user.bucket(
159 'ext.articleFeedback-tracking', mw.config.get( 'wgArticleFeedbackTracking' )
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
@@ -3,6 +3,12 @@
44 */
55
66 jQuery( function( $ ) {
 7+ // HACK: This code is broken in IE7 and below, so if this is IE < 8, bail now
 8+ var browser = $.client.profile();
 9+ if ( browser.name === 'msie' && browser.versionNumber < 8 ) {
 10+ return;
 11+ }
 12+
713 // Load check, is this page ArticleFeedback-enabled ?
814 // Keep in sync with ApiArticleFeedback.php
915 if (

Follow-up revisions

RevisionCommit summaryAuthorDate
r1034591.18wmf1: MFT r103456catrope12:41, 17 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101461Hack for bug 31543: disable ArticleFeedback on IE7 and belowcatrope08:53, 1 November 2011

Status & tagging log